[PATCH 1/3] create_symref: check error return from open().
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:51
Subsystem:
the rest · Maintainer:
Linus Torvalds
Signed-off-by: Junio C Hamano <redacted> --- * There seem to be similarly "casual" users of open in the rest of the code, but I noticed this while looking at your series. I've already done the necessary shuffling in my tree, so there is no need to resend your "move create_symref()". refs.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/refs.c b/refs.c
index 0840b3b..12e46b8 100644
--- a/refs.c
+++ b/refs.c@@ -331,7 +331,11 @@ int create_symref(const char *ref_target, const char *refs_heads_master) return -1; } lockpath = mkpath("%s.lock", git_HEAD); - fd = open(lockpath, O_CREAT | O_EXCL | O_WRONLY, 0666); + fd = open(lockpath, O_CREAT | O_EXCL | O_WRONLY, 0666); + if (fd < 0) { + error("Unable to open %s for writing", lockpath); + return -5; + } written = write_in_full(fd, ref, len); close(fd); if (written != len) {
--
1.5.0.rc2.g8ac6-dirty