Re: [PATCH] sha1_file.c: Avoid multiple calls to find_pack_entry().

Simon 'corecode' Schubert [off-list ref] wrote:

Peter Eriksen wrote:

quoted

We used to call find_pack_entry() twice from read_sha1_file() in order
to avoid printing an error message, when the object did not exist.  This
is fixed by moving the call to error() to the only place it really
could be called.

Signed-off-by: Peter Eriksen <redacted>

I noticed this originally, Peter was so kind to come up with a patch.  
Reviewed and found +1, so:

Signed-off-by: Simon 'corecode' Schubert <redacted>

Wow.  That's ugly.  Thanks for finding and patching it.

-- 
Shawn.