Thread (3 messages) flat view 3 messages, 3 authors, 2016-06-15

Re: [PATCH] prune: --expire=time

From: Matthias Lederhofer <hidden>
Date: 2016-06-15 22:42:50

Possibly related (same subject, not in this thread)

Junio C Hamano [off-list ref] wrote:
I am considering to commit the attached instead.
Looks fine.  Just one question:  You said normally unsigned long would
be used for time_t but time_t itself seems to be signed.  Using
unsigned long instead of int for prune_grace_period (which is used as
time_t here) results in 'warning: comparison between signed and
unsigned'.  Perhaps you want to change it here anyway to be consistent
with the rest of the code (approxidate returns unsigned long too).
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help