Thread (32 messages) flat view 32 messages, 12 authors, 2016-06-15

Re: [PATCH/POLL] git-format-patch: the default suffix is now .patch, not .txt

From: Johannes Sixt <hidden>
Date: 2016-06-15 22:42:49

"Shawn O. Pearce" wrote:
AFAIK there's not a strong reason to keep fork() in Git.

Currently anytime we fork a process its to perform a small amount
of file descriptor redirection and then immediately exec some other
executable, or a hook script.  In other words we probably could
convert all current uses of fork to something like in run-command.c,
which a Windows port could then easily replace using CreateProcess().

But removing fork isn't worth doing until someone is seriously
trying to port Git onto Windows without Cygwin.  The current code
works on sane OSes and isn't broken, so why fix it?
I'm doing just that (MinGW port).

I've come up with a function spawnvpe_pipe(), which hides all the scary
details of fork+exec with dup2's and close's. It could probably easily
be merged into run_command(), but I haven't tried that, yet.

I'll try to push out what I have to repo.or.cz over the weekend. 

-- Hannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help