Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] Change to the repository's root directory if needed.

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:49

Steven Grimm [off-list ref] writes:
Junio C Hamano wrote:
quoted
Porcelains that define SUBDIRECTORY_OK but do not do cdup are
very valid, and they should not be cd'ed up automatically.
My patch doesn't do the cd if SUBDIRECTORY_OK is defined, for exactly
that reason.
Ah, I misread the patch.  Sorry.

But the point is that the scripts that do not currently say
SUBDIRECTORY_OK have not even been audited to see if it makes
sense to always cd to the top.  Isn't your patch making as if
they are saying SUBDIRECTORY_OK=Yes and cd to the top upfront is
the right thing to do?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help