Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 3/3] Use /dev/null for update hook stdin.

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:47

"Shawn O. Pearce" [off-list ref] writes:
Currently the update hook invoked by receive-pack has its stdin
connected to the pushing client.  The hook shouldn't attempt to
read from this stream, and doing so may consume data that was
meant for receive-pack.  Instead we should give the update hook
/dev/null as its stdin, ensuring that it always receives EOF and
doesn't disrupt the protocol if it attempts to read any data.
Both 2 and 3 look sane, but can we have a few new tests too?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help