Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] Checking for "diff.color." should come before "diff.color"

From: Andy Parkins <hidden>
Date: 2016-06-15 22:42:45

On Monday 2006, October 23 21:29, Junio C Hamano wrote:
Andy Parkins [off-list ref] writes:
quoted
In git_diff_ui_config() the strncmp() for "diff.color" would have matched
for "diff.color.", so "diff.color." configs would never be processed.
A test case that demonstrates the breakage without the patch
would be nice. Could you come up with a two-patch series that
is:
No need.  Jeff King already caught the fact that my patch is unnecessary.  I 
withdraw it.

Sorry to keep bothering you all with these non-entity patches.  I really am 
only trying to help :-)


Andy

-- 
Dr Andrew Parkins, M Eng (Hons), AMIEE
andyparkins@gmail.com

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help