Thread (1 message) 1 message, 1 author, 2016-06-15

Re: git-fetch --update-head-ok ?

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:43

Martin Waitz [off-list ref] writes:
I have no idea why there is a --update-head-ok, but the code looks
like it has a typo:
I looked at it again, and indeed it looks like a typo.
quoted hunk
@@ -433,7 +433,7 @@ esac
 # If the original head was empty (i.e. no "master" yet), or
 # if we were told not to worry, we do not have to check.
 case ",$update_head_ok,$orig_head," in
-*,, | t,* )
+*,, | ,t,* )
        ;;
 *)
        curr_head=$(git-rev-parse --verify HEAD 2>/dev/null)
Interestingly enough, when update_head_ok is set, orig_head
never is so the typo does not matter at all by pure accident (it
was there from the very first version that introduced this
feature).

It should just be something like this:

        case "$orig_head" in
        '')
                ;;
        ?*)
                curr_head=$(git-rev-parse --verify HEAD 2>/dev/null)
                ...
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help