Thread (3 messages) flat view 3 messages, 3 authors, 2016-06-15

Re: [PATCH] gitweb: Cleanup Git logo and Git logo target generation

From: Jakub Narebski <hidden>
Date: 2016-06-15 22:42:43

Junio C Hamano wrote:
Jakub Narebski [off-list ref] writes:
quoted
Partial improvement is better than no improvement.
Not necessarily.  As the maintainer, I found that when we say
"we will fix it later", later tend to never come, and one
effective way to fight that tendency is to prod the contributors
a bit harder, which worked reasonably well so far.
Well. Perhaps.

But first, it is also bugfix for esc_html on URL, and second I though 
you rather have one feature per patch; this one has two - cleanup of 
logo generation, and moving style to CSS. "Better" patch would have 
three...

-- 
Jakub Narebski
Poland
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help