Re: gitweb: using quotemeta

Dear diary, on Fri, Oct 06, 2006 at 08:21:05PM CEST, I got a letter
where Luben Tuikov [off-list ref] said that...

quoted

According to RFC2183, the filename is a value. According to RFC2045, a
value is either a token (uninteresting) or a quoted-string. According to
RFC822:

     quoted-string = <"> *(qtext/quoted-pair) <">; Regular qtext or
                                                 ;   quoted chars.

     qtext       =  <any CHAR excepting <">,     ; => may be folded
                     "\" & CR, and including
                     linear-white-space>

     quoted-pair =  "\" CHAR                     ; may quote any char

So what we emit is completely correct.

(Your quotations do not seem correct according to 
  ftp://ftp.rfc-editor.org/in-notes/rfc2045.txt !)

Wow, you caused my GNOME at work to do something totally horrible after
me clicking on that link... ;-)

I'm not sure how is RFC2045 relevant - this is from RFC822, RFC2045 does
not define those non-terminals.

Petr, I agree with your that what we emit is "completely correct".

But is is _mangled_.  I.e. why mangle the filename from "a.b" to
"a\.b" ?  Indeed the latter _is_ qtext but it is not the original name
given to the file.

..snip..

Sorry, I ment to say that the latter doesn't appear to be qtext.

Bottomline is that quotemeta does not convert into qtext, and as thus
should never have been used.

It's a moot point now, but I don't see that - inside qtext, any
character can be quoted, so what we do is technically ok.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj
$/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1
lK[d2%Sa2/d0$^Ixp"|dc`;s/\W//g;$_=pack('H*',/((..)*)$/)