Re: [PATCH] gitweb: start to generate PATH_INFO URLs.

Jakub Narebski [off-list ref] writes:

Junio C Hamano wrote:

quoted

Jakub Narebski [off-list ref] writes:

quoted

Martin Waitz wrote:

quoted

+       'pathinfo' => {
+               'override' => 0,
+               'default' => [1]},

You should add failsafe to gitweb_check_feature for when 'sub' is not

set;

quoted

quoted

for example when somebody sets $feature{'pathinfo'}{'override'} to 1.

Yes, I noticed this last night while playing with it.  We would
at least need a big warning that says this should not be made
overridable (which does not make any sense anyway).

Setting 'sub' to a failsafe one that only returns what is in the
default without looking at individual repository would be the
cleanest, I think.

Perhaps we should not add 'override' key, and test for existence
of 'override' to fallback on 'sub'.

Excellent idea.  Please make it so.