Re: [PATCH 5/5] fetch: Clean output
From: Santi <hidden>
Date: 2016-06-15 22:42:42
2006/9/30, Junio C Hamano [off-list ref]:
Santi Béjar [off-list ref] writes:quoted
Do not show duplicated remote branch information and reformat the output as: $ git fetch -v # the committish lines for the -v. * refs/heads/origin: fast forward to remote branch 'master' of ../git/ 1ad7a06..bc1a580 committish: bc1a580I am not quite sure about this --- it is not obvious what these two numbers represent anymore. Also I think the last line outlived its usefulness (99% of the time refs are committish, so noting exception is good but otherwise it is not interesting).
I agree in the case of updating a ref, but I would keep it otherwise (and even in this case only when -v is given).
I know you opted for minimum patch, but it might be a good time to polish the wording a bit while we are touching the general vicinity of the code. How about saying something like: * refs/heads/origin: fast forward to remote branch 'master' of ../git/ old..new = 1ad7a06..bc1a580
I like it.
quoted
* refs/heads/pu: does not fast forward to remote branch 'pu' of ../git/; 7c733a8...5faa935 not updating. forcing update. committish: 5faa935This is even more confusing. Perhaps we would want to have two cases, depending on --force (and +).
Sorry, it was from two copy'n'paste. I did it in a new repository (without the +), then it stoped at this point (I suppose to force the user to solve the problem). Then I put the + and did the copy'n'paste again without deleting this extra line.
* refs/heads/pu: does not fast forward to remote branch 'pu' of ../git/; but forcing update anyway. old...new = 7c733a8...5faa935
With the old...new in a new line? So at the end, something like this output? $ git fetch -v # the committish lines for the -v. * refs/heads/origin: fast forward to remote branch 'master' of ../git/ old..new: 1ad7a06..bc1a580 * refs/heads/pu: does not fast forward to remote branch 'pu' of ../git/ old...new: 7c733a8...5faa935 forcing update. * refs/heads/next: same as remote branch 'origin/next' of ../git/ committish: ce47b9f ... * refs/tags/v1.4.2-rc4: storing tag 'v1.4.2-rc4' of ../git/ committish: 8c7a107 $ git fetch -v origin refs/heads/master * committish: 695dffe branch 'master' of ../git/ Santi