Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [RFC/PATCH] gitweb: Add committags support

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:41

Jakub Narebski [off-list ref] writes:
Don't forget about final s,\n,<br/>\n,gm if we parse it as a whole,
and not line by line. 
Yes, the driver and individual tag markers need to have a
convention on who is responsible for doing <br />.
One reasonable convention would be to make the driver side
responsible for taking \n and turns it into <br /> in plain
strings, and make the tag markers responsible for doing so in
their marked-up output.

For example, when bugzilla_tagger is annotating this commit
message:

    This rewrites frotz() routine to work around Bug
    #22574.  The fix was confirmed by Xyzzy.

    Thanks for everybody who helped with this rewrite.

it would match with a regexp /\b(?i:bug)\s*#?(\d+)/s
to pick up "Bug\n#22574", extract 22574, and produce:

    ('This rewrites frotz() routine to work around ',
     \'<a href="/cgi-bin/bugzilla.cgi?id=22574">Bug<br/>#22574</a>',
     '.  The fix was confirmed by Xyzzy.\n\nThanks for everybody...')
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help