Re: [RFC][PATCH] gitweb: Make the Git logo link target to point to the homepage

Jakub Narebski [off-list ref] writes:

Junio C Hamano wrote:

quoted

-             "<a href=\"http://www.kernel.org/pub/software/scm/git/docs/\" title=\"git documentation\">" .
+             "<a href=\"" . esc_html($githelp_url) .
+             "\" title=\"" . esc_html($githelp_label) .
+             "\">" .

Why not use $cgi->a_begin({-href=>esc_param($githelp_url), -title=>$githelp_label});
or just plain $cgi->a and $cgi->img?

Be my guest and send in a proper patch please.

I was merely demonstrating my preference on how definition of
default values and actual use of them are separated.