Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] Make cvsexportcommit work with filenames containing spaces.

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:41

Robin Rosenberg [off-list ref] writes:
Why patch? Well this patch works around (i.e. not perfect) a mismatch between 
what patch eats and git submits. They are not totally, compatible, and I'm 
not sure who to blame yet.  git emits diff's without timestamps, and what 
matters to patch, without a TAB before the file timestamp. When patch sees a 
header like "+++ filename with spaces.txt" it patches "filename". When it 
sees "+++ filename with spaces.txt<TAB>" if patches "filename with 
spaces.txt". The real fix would ofcourse be in git diff or patch sometime in 
the future.
Ah, it might be because our diff output do not have trailing TAB
(and timestamp) and if CVS uses GNU patch that would be confused
and not detect the file being patched.

Interestingly, I did a two-patch series to address that issue
separately.  But that is not even in "next" yet.

More interestingly, the version of "GNU patch" that cannot grok
our patch (without trailing TAB) for a file that has SP in its
name is on my home machine where your patched cvsexportcommit
works.  I do not know if GNU patch on the other machine does.

Will collect necessary info and follow up.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help