Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] gitweb: Fix showing of path in tree view

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:41

Petr Baudis [off-list ref] writes:
quoted
Hmph.  I see the breakage and behaviour-wise your patch is fine.

But I think the older one was visually nicer and more intuitive
in one very small detail that I think matters.  Slashes between
path components were not part of the anchor elements, so it was
clear that there were two links in "gitweb / gitweb.perl" page
title, not just one link.  Now it is not obvious that clicking
different parts of the path string in "/stgit/commands/mail.py"
would lead to different places.  And as you are aware, losing
the leading "/" would be nicer as well ;-).
  Well, this was the best I could come up without introducing "[root] /"
or something in front of the path, which would be IMHO even uglier.
Alternative ideas welcomed. :-)
Ok, when I commented on it I did not realize that the leading
slash was clickable.

How about rendering it like this?

	/ stgit/ commands/ mail.py
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help