Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] gitweb fix validating pg (page) parameter

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:40

Matthias Lederhofer [off-list ref] writes:
quoted
quoted
+	if ($page =~ m/[^0-9]/) {
...
The first page seems to have number 0.  After removing the 1 <= $page
this code should do the same as my patch, apply whatever you think is
easier to read (I prefer if over unless most of the time).
Ah, I did not notice we call the first page 0; barfing on any
non-digit in the string like you do sounds quite sane.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help