Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH] pack-objects: re-validate data we copy from elsewhere.

From: Shawn Pearce <hidden>
Date: 2016-06-15 22:42:39

Junio C Hamano [off-list ref] wrote:
Shawn Pearce [off-list ref] writes:
quoted
Junio C Hamano [off-list ref] wrote:
quoted
If rev-list had an extention that lets you say

	rev-list --objects --all --unpacked=$active_pack |
	pack-objects $new_pack
Hmm.  Seems very reasonable actually.  :-)

How do we pick the "active pack" in git-repack.sh?
I was hoping that will be a Porcelain policy issue I do not have
to decide ;-).
But would need to update git-repack.sh.  :-)
 
You could introduce repack.active in .git/config that points at
the latest active, make git-repack to notice and update when it
updates it.
No.  I don't think its a good idea for git-repack to be updating
your configuration file during a repack.  If something goes badly
there you could lose settings you would rather not lose.

Better that it update a symref like thing instead.  For example
create a ".git/objects/pack/active" file holding the name
("pack-n{40}.pack") of the current active pack.  If this file is
missing choose the pack that is smallest as the active pack.

-- 
Shawn.

-- 
VGER BF report: S 0.999999
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help