Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] gitweb: bugfix: list regression

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:37

Luben Tuikov [off-list ref] writes:
Fix regression introduced by
commit 17d07443188909ef5f8b8c24043cb6d9fef51bca.

1. Commit 17d07443188909ef5f8b8c24043cb6d9fef51bca defines
"a.list" twice in gitweb.css, once with bold and once with
normal font-weight.
The normal one is limited to a.list that is inside table.tags
isn't it?  I had an impression that this was done on purpose.
2. "a.list" being "bold", makes a myriad of things shown by
gitweb in bold font-weight, which is a regression from
pre-17d07443188909ef5f8b8c24043cb6d9fef51bca behavior.
The only difference I see offhand is that Jakub's version shows
the tag text in normal weight in summary pane (tags section),
while yours show it in bold.  Also clickable object names in
many views are shown in bold in Jakub's version while yours do
not distinguish them from unclickable ones.

I tend to agree that bold looks too loud in tree view, but
showing tree and parent diffently from commit itself in commit
view may be a good thing.  I am not sure bold is a good choice,
though.  Usually people underline clickable links not type in
bold.

I do not case either way myself that much.  Could you battle
this out with the guilty party?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help