[PATCH] gitweb: bugfix: list regression
From: Luben Tuikov <hidden>
Date: 2016-06-15 22:42:37
Subsystem:
the rest · Maintainer:
Linus Torvalds
Fix regression introduced by commit 17d07443188909ef5f8b8c24043cb6d9fef51bca. 1. Commit 17d07443188909ef5f8b8c24043cb6d9fef51bca defines "a.list" twice in gitweb.css, once with bold and once with normal font-weight. 2. "a.list" being "bold", makes a myriad of things shown by gitweb in bold font-weight, which is a regression from pre-17d07443188909ef5f8b8c24043cb6d9fef51bca behavior. The fix is to define separately "a.list_bold" and use that style in format_subject_html(). Signed-off-by: Luben Tuikov <redacted> --- gitweb/gitweb.css | 9 +++++++-- gitweb/gitweb.perl | 4 ++-- 2 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/gitweb/gitweb.css b/gitweb/gitweb.css
index 9013895..db58629 100644
--- a/gitweb/gitweb.css
+++ b/gitweb/gitweb.css@@ -115,13 +115,18 @@ div.list_head { font-style: italic; } -a.list { +a.list_bold { text-decoration: none; font-weight: bold; color: #000000; } -table.tags a.list { +a.list { + text-decoration: none; + color: #000000; +} + +table.tags { font-weight: normal; }
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 063735d..5237f25 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl@@ -504,11 +504,11 @@ sub format_subject_html { $extra = '' unless defined($extra); if (length($short) < length($long)) { - return $cgi->a({-href => $href, -class => "list", + return $cgi->a({-href => $href, -class => "list_bold", -title => $long}, esc_html($short) . $extra); } else { - return $cgi->a({-href => $href, -class => "list"}, + return $cgi->a({-href => $href, -class => "list_bold"}, esc_html($long) . $extra); } }
--
1.4.2.g3851f