Re: [PATCH 4/4] gitweb: No periods for error messages
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:35
Luben Tuikov [off-list ref] writes:
quoted hunk
--- Junio C Hamano <junkio@cox.net> wrote:quoted
I tend to prefer ending each sentence with a full stop.I've never seen this in, among other things, - kernel messages - errno messages - web server messages - RFC text describing error messages, (web services), - etc.
Comparing git grep \( -e die --or -e die \) --and -e '\."' -- '*.c' and git grep \( -e die --or -e die \) --and --not -e '\."' -- '*.c' tells me that we omit periods, mostly.
I was going for was consistency. I'd say apply Jacob's [6/5].
Well, [6/5] is on top of [1/5] which had the problem of parroting unsanitized user input, so I'd rather use a clean patch that does only this error message cleanups.