Re: update-ref logs: problem with committer info?
From: Shawn Pearce <hidden>
Date: 2016-06-15 22:42:35
Ramsay Jones [off-list ref] wrote:
quoted hunk ↗ jump to hunk
diff --git a/builtin-update-ref.c b/builtin-update-ref.c index 00333c7..83094ab 100644 --- a/builtin-update-ref.c +++ b/builtin-update-ref.c@@ -12,6 +12,7 @@ int cmd_update_ref(int argc, const char unsigned char sha1[20], oldsha1[20]; int i; + setup_ident(); setup_git_directory(); git_config(git_default_config);diff --git a/refs.c b/refs.c index 713ca46..a4060d8 100644 --- a/refs.c +++ b/refs.c@@ -379,7 +379,6 @@ static int log_ref_write(struct ref_lock lock->log_file, strerror(errno)); } - setup_ident(); comitter = git_committer_info(1); if (msg) { maxlen = strlen(comitter) + strlen(msg) + 2*40 + 5;
These two changes were already fixed by me in 0b0fe4a6 on July 10th. That change is in `next`, in `master` and in v1.4.2-rc3. So I expect it to be available in a final release real-soon-now. Maybe you should consider running a newer version of GIT?
quoted hunk ↗ jump to hunk
diff --git a/http-fetch.c b/http-fetch.c index 44eba5f..fe3a4fd 100644 --- a/http-fetch.c +++ b/http-fetch.c@@ -1222,6 +1222,7 @@ int main(int argc, char **argv) int arg = 1; int rc = 0; + setup_ident(); setup_git_directory(); git_config(git_default_config);diff --git a/local-fetch.c b/local-fetch.c index ffa4887..d059a51 100644 --- a/local-fetch.c +++ b/local-fetch.c@@ -207,6 +207,7 @@ int main(int argc, char **argv) char *commit_id; int arg = 1; + setup_ident(); setup_git_directory(); git_config(git_default_config);diff --git a/ssh-fetch.c b/ssh-fetch.c index 1e59cd2..a42d17e 100644 --- a/ssh-fetch.c +++ b/ssh-fetch.c@@ -131,6 +131,7 @@ int main(int argc, char **argv) prog = getenv("GIT_SSH_PUSH"); if (!prog) prog = "git-ssh-upload"; + setup_ident(); setup_git_directory(); git_config(git_default_config);
These changes aren't in `next` right now, but should be. Junio, can you apply them? -- Shawn.