Re: [PATCH] gitweb: fill in gitweb configuration by Makefile

--- Martin Waitz <tali@admingilde.org> wrote:

quoted

Generate gitweb/gitweb.cgi to reduce the need to patch gitweb.cgi by
the end user.
The GIT installation directory and version are already known by the
Makefile, they can be inserted directly into gitweb.
All other gitweb configuration parameters can now be specified
by providing GITWEB_* variables while building GIT.
These are described in gitweb/README.

NACK.

I don't like it.  While this method works, it is too much effort
to have to run make to do this, plus it pollutes your tree.

Instead, what you can do is make gitweb.cgi read a text file
from . which has those variables defined.

This way, I can just copy gitweb.cgi into my web-server directory
and voila it works, since the variable definition file would
always be there.  This way:
  - no need to run make to build "gitweb.cgi" or "gitweb.pl" whatever
    you call it,
  - no need to pollute your tree with site defined variables,
  - simple copy (cp) would install a working version, instead of
    the current cp + patch with local settings method.

   Luben