Re: [PATCH] gitweb: fix two warnings
From: Luben Tuikov <hidden>
Date: 2016-06-15 22:42:34
--- Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:quoted hunk ↗ jump to hunk
These warnings cluttered up my log. Signed-off-by: Johannes Schindelin <redacted> --- gitweb/gitweb.cgi | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)diff --git a/gitweb/gitweb.cgi b/gitweb/gitweb.cgi index e226ac2..e5fca63 100755 --- a/gitweb/gitweb.cgi +++ b/gitweb/gitweb.cgi@@ -795,7 +795,7 @@ sub git_read_projects { if (-d $projects_list) { # search in directory my $dir = $projects_list; - opendir my $dh, $dir or return undef; + opendir my ($dh), $dir or return undef; while (my $dir = readdir($dh)) { if (-e "$projectroot/$dir/HEAD") { my $pr = {@@ -810,7 +810,7 @@ sub git_read_projects { # 'git%2Fgit.git Linus+Torvalds' # 'libs%2Fklibc%2Fklibc.git H.+Peter+Anvin' # 'linux%2Fhotplug%2Fudev.git Greg+Kroah-Hartman' - open my $fd , $projects_list or return undef; + open my ($fd), $projects_list or return undef; while (my $line = <$fd>) { chomp $line; my ($path, $owner) = split ' ', $line;-- 1.4.2.rc2.g6a4e
Can you please give more details of the warnings, cut-and-paste would be nice, the problem as you perceive it, and your solution to it? Thanks, Luben