Re: [PATCH] cvsserver: suppress warnings

Johannes Schindelin wrote:

This patch defines $state->{prependdir} as the empty string, so that
quite a few warnings are avoided.

Ack.

	I still get this warning:

		closing dbh with active statement handles

Ack to that too. Perhaps an END block would help? A quick check of man 
DBI tells me that $dbh->CachedKids will be a hashref where the values 
are refs to the cached statement handles.

IMHO it's a DBI bug -- statement handles only referenced by 
$dbh->CachedKids should cleanup silently. prepare_cached() is a 
convenience method so that you _don't_ have to keep track of the handles 
manually. Forcing a manual cleanup throws a good part of the convenience 
out.

cheers,



martin
-- 
-----------------------------------------------------------------------
Martin @ Catalyst .Net .NZ  Ltd, PO Box 11-053, Manners St,  Wellington
WEB: http://catalyst.net.nz/           PHYS: Level 2, 150-154 Willis St
OFFICE: +64(4)916-7224                              MOB: +64(21)364-017
       Make things as simple as possible, but no simpler - Einstein
-----------------------------------------------------------------------