Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] upload-pack: fix timeout in create_pack_file

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:34

Matthias Lederhofer [off-list ref] writes:
Junio C Hamano [off-list ref] wrote:
quoted
My gut feeling is that your patch would be fine as is (have you
tried and confirmed that it helps cases other than slow
clients?)
... I tried a server with --timeout=600 and a client
that cannot download the whole pack file in 10 minutes.  Without the
patch the server closes the connection, with this patch it works.
Additionally I tried it with a client reading so slow that the server
was blocked for more than --timeout seconds, then the server closes
the connection too (this is more or less the DoS case).
Thanks, that's all I wanted to know.  Let's have it.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help