Re: [PATCH] gitweb.cgi: Teach tree->raw to not require the hash of the blob

--- Junio C Hamano <junkio@cox.net> wrote:

Luben Tuikov [off-list ref] writes:

quoted

Teach tree->raw to not require the hash of the blob, but to
figure it out from the file name.  This allows to externally
link to files into the repository, such that the hash is not
required.  I.e. the file obtained would be as of the HEAD
commit.

In contrast tree->blob for binary files passes the hash, as
does tree->blob->plain for "text/*" files.

Signed-off-by: Luben Tuikov <redacted>
---
 gitweb/gitweb.cgi |   20 ++++++++++++++++----
 1 files changed, 16 insertions(+), 4 deletions(-)

This has exactly the same line number problem.

[cut]

Hand-applied, tried, got confused and dropped.

I'll regenerate and send it to the list.

I think _allowing_ to accept filename not hash is a sane change,
and would be useful if you want to allow linking to always the
HEAD version from external sites,

Indeed, it is useful.

but I do not think listing the
raw link in the tree view without the hash is a good idea.  It
makes things quite confusing that "blob" link in its
neighbourhood gives the blob from that specific version, but
"raw" gives the version from HEAD, even when you are browsing
something other than HEAD.

I just thought it to be an easy place to put the "raw"-no-hash
link.

BTW, Junio, it would be a shame to lose this capability.  How
would you like to proceed with this?  Where would you like to
see this kind of link go?

BTW, can somebody volunteer to be a gitweb/ "subsystem
maintainer"?

Make sure you pick someone liberal without personal aspirations
or turning it into a personal crusade.  Service to the community
(not self, or company XYZ) is best.

    Luben