Re: [PATCH 2/3] sha1_file: add the ability to parse objects in "pack file format"

Hi,

On Tue, 11 Jul 2006, Linus Torvalds wrote:

On Tue, 11 Jul 2006, Johannes Schindelin wrote:

quoted

quoted

Or, more likely, the parse_sha1_header() function should just be changed 
to check the binary format first (and then add your comment about why that 
is safe).

Yes, exactly.

Here's a newer verson of [2/3], with these issues fixed. It actually fixes 
things twice: (a) by parsing the binary version first (which makes sense 
for a totally independent reason - if that is going to be the "default" 
version in the long run, we should just test it first anyway) and (b) by 
making the ASCII version parser stricter too.

Melikey.

Ciao,
Dscho