Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] Fix errno usage in connect.c

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:32

Petr Baudis [off-list ref] writes:
Dear diary, on Wed, Jun 28, 2006 at 06:56:12PM CEST, I got a letter
where Morten Welinder [off-list ref] said that...
quoted
It looks like connect.c waits too long before it uses errno in both copies
of git_tcp_connect_sock.  Both close and freeaddrinfo can poke any
non-zero value in there.
Nice catch.

->8-

errno was used after it could've been modified by a subsequent library call.
Spotted by Morten Welinder.

Signed-off-by: Petr Baudis <redacted>
Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help