[PATCH 3/3] Make clear_commit_marks() clean harder
From: Rene Scharfe <hidden>
Date: 2016-06-15 22:42:32
Subsystem:
the rest · Maintainer:
Linus Torvalds
Possibly related (same subject, not in this thread)
- 2016-06-15 · Re: [PATCH 3/3] Make clear_commit_marks() clean harder · Junio C Hamano <hidden>
- 2016-06-15 · Re: [PATCH 3/3] Make clear_commit_marks() clean harder · Johannes Schindelin <hidden>
- 2016-06-15 · Re: [PATCH 3/3] Make clear_commit_marks() clean harder · Linus Torvalds <torvalds@osdl.org>
- 2016-06-15 · Re: [PATCH 3/3] Make clear_commit_marks() clean harder · Junio C Hamano <hidden>
- 2016-06-15 · Re: [PATCH 3/3] Make clear_commit_marks() clean harder · Johannes Schindelin <hidden>
Don't care if objects have been parsed or not and don't stop when we reach a commit that is already clean -- its parents could be dirty. Signed-off-by: Rene Scharfe <redacted> --- commit.c | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/commit.c b/commit.c
index 593414d..70a4eff 100644
--- a/commit.c
+++ b/commit.c@@ -397,13 +397,12 @@ void clear_commit_marks(struct commit *c { struct commit_list *parents; + if (!commit) + return; parents = commit->parents; commit->object.flags &= ~mark; while (parents) { - struct commit *parent = parents->item; - if (parent && parent->object.parsed && - (parent->object.flags & mark)) - clear_commit_marks(parent, mark); + clear_commit_marks(parents->item, mark); parents = parents->next; } }
--
1.4.1.rc2.gfc04