Re: [PATCH 1/3] Fix probing for already installed Error.pm
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:31
Pavel Roskin [off-list ref] writes:
quoted hunk
diff --git a/perl/Makefile.PL b/perl/Makefile.PL index d401a66..b3fbb73 100644 --- a/perl/Makefile.PL +++ b/perl/Makefile.PL@@ -12,7 +12,7 @@ my %pm = ('Git.pm' => '$(INST_LIBDIR)/Gi # We come with our own bundled Error.pm. It's not in the set of default # Perl modules so install it if it's not available on the system yet. -eval { require 'Error' }; +eval { require Error }; if ($@) { $pm{'Error.pm'} = '$(INST_LIBDIR)/Error.pm'; }
The syntax updates is correct, but this is still wrong, I am afraid. It is trying to see if we need to install the Error.pm we ship just in case the system does not have Error.pm available. But this script is run in perl/ directory where we have that private copy of Error.pm, so "require Error" always succeeds, eh, at least after you fixed the above syntax error X-<.