Re: [PATCH 3/2] format-patch: use clear_commit_marks() instead of some adhocery
From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:42:31
Possibly related (same subject, not in this thread)
- 2016-06-15 · [PATCH 3/2] format-patch: use clear_commit_marks() instead of some adhocery · Johannes Schindelin <hidden>
- 2016-06-15 · Re: [PATCH 3/2] format-patch: use clear_commit_marks() instead of some adhocery · Martin Langhoff <hidden>
- 2016-06-15 · Re: [PATCH 3/2] format-patch: use clear_commit_marks() instead of some adhocery · Junio C Hamano <hidden>
- 2016-06-15 · Re: [PATCH 3/2] format-patch: use clear_commit_marks() instead of some adhocery · Martin Langhoff <hidden>
- 2016-06-15 · Re: [PATCH 3/2] format-patch: use clear_commit_marks() instead of some adhocery · Johannes Schindelin <hidden>
Hi, On Mon, 26 Jun 2006, Junio C Hamano wrote:
quoted hunk ↗ jump to hunk
diff --git a/commit.c b/commit.c index 946615d..69fbc41 100644 --- a/commit.c +++ b/commit.c@@ -397,8 +397,7 @@ void clear_commit_marks(struct commit *c commit->object.flags &= ~mark; while (parents) { struct commit *parent = parents->item; - if (parent && parent->object.parsed && - (parent->object.flags & mark)) + if (parent && (parent->object.flags & mark))
This is probably not necessary for existing users, but it's a good change for the future: new users might be surprised to learn that there are unparsed objects, which still want to be handled. Ciao, Dscho