Re: [PATCH] cvsimport - streamline temp index file creation and avoid creating empty tmpfiles

Martin Langhoff [off-list ref] writes:

On 6/24/06, Johannes Schindelin [off-list ref] wrote:

quoted

It seems that git-cvsimport makes a temporary file of size 0, which cannot
get mmap()ed, because it has size 0.

This switch to tmpnam() avoids creating the tmpfile in the first place and
streamlines the code. This handling of tmpfiles is slightly safer, but there
is an inherent race condition.

---
NOTE: (a) I cannot reproduce the problem and (b) this is only lightly tested,
if trivial.

Thanks both.

I'd take this to "next" after I hear from somebody, most likely
Johannes, who had trouble with the code earlier that the problem
is fixed.