Re: [PATCH] patch-id: "diff-tree" => "commit"

Hi,

On Fri, 23 Jun 2006, Linus Torvalds wrote:

On Fri, 23 Jun 2006, Johannes Schindelin wrote:

quoted

Some time ago we changed git-log in a massive way, and one consequence is
that the keyword changed. Adjust patch-id for that.

Ahh. Yes. Except I think you should allow both, for historical reasons (ie 
not remove the old case).

Hmm. If you are alluding to mailboxes, where there could be mails from 
older git versions, then this might not be enough. Look at my patch, for 
example. There is no "diff-tree", and no "commit".

However, the only official user of patch-id is git-cherry (and indirectly, 
all users of git-cherry). And this user works on data which is generated 
on the fly, i.e. there will be no "diff-tree" at the beginning.

Of course, there is a Pandora's box: a line in a commit message is much 
more likely to start with "commit <sha1>" than "diff-tree <sha1>". So my 
patch probably breaks many cases.

Ciao,
Dscho