Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] Check and document the options to prevent mistakes.

From: Eric W. Biederman <hidden>
Date: 2016-06-15 22:42:30

Junio C Hamano [off-list ref] writes:
ebiederm@xmission.com (Eric W. Biederman) writes:
quoted
+# Verify the user input
+
+foreach my $entry (@to) {
+	die "Comma in --to entry: $entry'\n" unless $entry !~ m/,/;
+}
+
Perhaps, avoiding double negation would be easier on the eyes.

        die ... if $entry =~ /,/
Sure double negation does get confusing.  I think I forgot about that
last if form.  My perl is rusty from disuse.  
Does it grok '"Biederman, Eric W." [off-list ref]' some people seem
to do properly, or do we care (I personally don't)?
Nope.  If figure that is lesser of two evils.  If I could properly
grok that I would make it do things properly and parse a --cc
option for multiple email addresses.

I think you can still specify those interesting forms in an alias
file, like .mailrc.

The important thing is not to do a mailing and the discover your
recipients didn't get the email.

Eric
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help