Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] Check and document the options to prevent mistakes.

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:30

ebiederm@xmission.com (Eric W. Biederman) writes:
+# Verify the user input
+
+foreach my $entry (@to) {
+	die "Comma in --to entry: $entry'\n" unless $entry !~ m/,/;
+}
+
Perhaps, avoiding double negation would be easier on the eyes.

        die ... if $entry =~ /,/

Does it grok '"Biederman, Eric W." [off-list ref]' some people seem
to do properly, or do we care (I personally don't)?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help