Re: git-applymbox broken?

On Sun, Jun 11, 2006 at 05:33:59PM -0600, Eric W. Biederman wrote:

Linus Torvalds [off-list ref] writes:

quoted

It looks like something has broken git-applymbox lately.

The "From: authorname" lines are no longer removed from the message, and 
are duplicated in the commit log. This has resulted in several recent 
kernel commits looking like this:

Agreed.  That isn't terribly desirable.
Do you have the original email message some place?

There is an odd case where if someone put the From: header
in the middle of the text that we now notice and process and I
didn't feel right about removing a line from the middle of the
text.

I was fixing a nasty corner case that happens if there aren't any
mail headers at all passed to git-mailinfo.  Where we could drop
lines without processing them at all.

This doesn't look like the From: header was in the middle of the
message until it was imported into git so it is probably a small
logic error that is easily corrected.  But I need to see what
we are parsing so I can understand what is happening.

I hate to say this, because I'm bad about it, too, but we should
probably have a few tests for applymbox, to cover the various scenarios
discussed in this thread.

-- 

Ryan Anderson
  sometimes Pug Majere