Re: [RFC][PATCH] Allow transfer of any valid sha1
From: Eric W. Biederman <hidden>
Date: 2016-06-15 22:42:27
Junio C Hamano [off-list ref] writes:
ebiederm@xmission.com (Eric W. Biederman) writes:quoted
So fixing fetch-pack is easy and pretty non-controversial. The patch below handles that.I am at work so I cannot really spend time on this right now, but I am OK with letting it send arbitrary SHA1 the caller obtained out of band. I do not know about your implementation, since I haven't really looked at it.
Agreed. I'm not certain about my implementation yet either I just know I was in the ball park. I needed the conversation to understand what the limits were.
quoted
(The movement of filter_refs may actually be overkill)It may not just overkill but may actively be wrong, but again I haven't looked at it yet. Will take a look tonight.
Sure. The code was all a work in progress so I don't expect to have all of the details ironed out. In particular I didn't even look at the non fetch-pack case, and I didn't update the documentation. Eric