Re: [PATCH 5/6] More accurately detect header lines in read_one_header_line

Junio C Hamano [off-list ref] writes:

Junio C Hamano [off-list ref] writes:

quoted

Was there a particular reason you needed this change?  That is,
did you have to parse mail-looking input that does not have a
blank line between runs of headers and the body of the message?

Yes.  I had patches that had a subject line followed by a blank line,
and the problem was that the old check thought the subject was a
header line, despite not even having a colon in it.

quoted

If so, I'd at least like to remove the || !isspace(colon[1])
from the test.  After all, I do not think RFC2822 requires a
whitespace after the colon there.

In other words, something like this (tested):

Looks good to me, sorry for missing that one.

Eric