Re: [PATCH] Documentation/Makefile: remove extra /
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:27
Martin Waitz [off-list ref] writes:
quoted hunk
As both DESTDIR and the prefix are supposed to be absolute pathnames they can simply be concatenated without an extra / (like in the main Makefile). The extra slash may even break installation on Windows. Signed-off-by: Martin Waitz <redacted> --- Documentation/Makefile | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)diff --git a/Documentation/Makefile b/Documentation/Makefile index 2a08f59..2b0efe7 100644 --- a/Documentation/Makefile +++ b/Documentation/Makefile@@ -52,9 +52,9 @@ man1: $(DOC_MAN1) man7: $(DOC_MAN7) install: man - $(INSTALL) -d -m755 $(DESTDIR)/$(man1) $(DESTDIR)/$(man7) - $(INSTALL) $(DOC_MAN1) $(DESTDIR)/$(man1) - $(INSTALL) $(DOC_MAN7) $(DESTDIR)/$(man7) + $(INSTALL) -d -m755 $(DESTDIR)$(man1) $(DESTDIR)$(man7) + $(INSTALL) $(DOC_MAN1) $(DESTDIR)$(man1) + $(INSTALL) $(DOC_MAN7) $(DESTDIR)$(man7)
This unfortunately breaks a workaround I did in the main Makefile for dist-doc target, but I agree it is a good change.