Re: [PATCH 2/2] cvsimport: cleanup commit function

[cc'd to list to get reactions on open2]

On Tue, May 23, 2006 at 12:10:08AM -0700, Junio C Hamano wrote:

quoted

+	return $s =~ /^[a-zA-Z0-9]{40}$/;

[0-9a-f] (We always do lowercase).

Er, yes, that was a complete think-o on my part.

Hmm.  I personally do not have problems with open2, but folks on
some other platforms might.  I'll see how the list audience
sounds.

FWIW, it was already being used in git-cvsimport.

-Peff