Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH] Transitively read alternatives

From: Jakub Narebski <hidden>
Date: 2016-06-15 22:42:25

Martin Waitz wrote:
When adding an alternate object store then add entries from its
info/alternates files, too.
Relative entries are only allowed in the current repository.
Loops and duplicate alternates through multiple repositories are ignored.
Just to be sure that nothing breaks it is not allow to build deep
nesting levels using info/alternates.
+     if (depth > 5) {
+             error("%s: ignoring alternate object stores, nesting too deep.",
+                             relative_base);
+             return;
+     }
Please, no magic numbers. Use preprocesor "constants" for that.

-- 
Jakub Narebski
Warsaw, Poland
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help