Thread (1 message) 1 message, 1 author, 2016-06-15

Re: RFC: New diff-delta.c implementation

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:24

Geert Bosch [off-list ref] writes:
That's about how I implemented it in my last patch.
Is it correct that 0 means that there is no max_size?
Should I set *delta_size to 0 when doing an early
return, or leave it alone?
When failing, I think
the convention is to return NULL and what you do with *delta_size
does not matter, but Nico and pack-objects.c code can answer
that better than I can ;-).
Note that this really is a micro-optimization,
True.  max_size is a hint, and the caller validates the size
independently anyway, so ignoring is fine.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help