Re: [PATCH] cvsimport: use git-update-ref when updating

Johannes Schindelin [off-list ref] wrote:

Hi,

On Thu, 30 Mar 2006, Junio C Hamano wrote:

quoted

Johannes Schindelin [off-list ref] writes:

quoted

This simplifies code, and also fixes a subtle bug: when importing in a
shared repository, where another user last imported from CVS, cvsimport
used to complain that it could not open <branch> for update.

The second hunk look sensible but I do not know about "use Fcntl"
since I do not see anything you are adding that starts to use it...

O_EXCL. Without "use Fcntl;" perl says I am not allowed to use bareword 
things in strict mode or some such.

Huh?  I still don't see where O_EXCL is used.

quoted

quoted

+       system("git-update-ref refs/heads/$branch $cid") == 0

Passing args to system() in list form is always preferable in case
there's a shell-unfriendly variable:

	system("git-update-ref", "refs/heads/$branch", $cid) == 0

-- 
Eric Wong