Thread (16 messages) flat view 16 messages, 8 authors, 2016-06-15

Re: Use a *real* built-in diff generator

From: Linus Torvalds <torvalds@osdl.org>
Date: 2016-06-15 22:42:22


On Sat, 25 Mar 2006, Morten Welinder wrote:
The primary correctness concern is that patch understands
the output, ie., the libxdiff + patch brings out right back.

It ought to be fairly easy to script checking every file change
that ever went into a git repository.  You won't cover evil
cases that way, but it should provide some assurances that
nothing is too wrong.
I did _some_ tests, and especially "git-apply" is very useful, since it is 
actually a lot more anal than regular "patch".

It all worked fine except for files that don't end with a newline. Davide 
points out that he just forces the EOLN at the end in his test harness, 
but that's not exactly acceptable for a real project that actually has 
real cases.

I'll be taking a look at trying to fix it. 

		Linus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help