Thread (6 messages) flat view 6 messages, 2 authors, 2016-06-15

Re: [PATCH 0/3] Teach git-blame about renames

From: Fredrik Kuivinen <hidden>
Date: 2016-06-15 22:42:21

On Wed, Mar 08, 2006 at 04:27:02PM -0800, Junio C Hamano wrote:
quoted
-static int compare_tree(struct tree *t1, struct tree *t2)
+int compare_tree(struct tree *t1, struct tree *t2)
...
-static int same_tree_as_empty(struct tree *t1)
+int same_tree_as_empty(struct tree *t1)
Maybe the names are a bit too generic to be used as a global?
Yes.. maybe. They are quite general though. Any suggestions for better
names? We could prefix everything in revision.h with "rev_" or
something like that.


Thanks for the comments. I will send an updated patch series soon.

- Fredrik
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help