Re: Make git diff-generation use a simpler spawn-like interface

Linus Torvalds [off-list ref] writes:

This actually ends up simplifying the code, and should make it much
easier to make it efficient under broken operating systems (read: Windows).

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
---

Now, somebody else might disagree with my contention that this also makes 
things simpler, but I like how we separate out the "run an external 
program" phase from the actual setup and header printing phase.

I agree this is going in the right direction.

A note that is offtopic to this particular patch but is related
to Andrew's point.  I had a wrong version of pre-applypatch hook
in the sample shipped as "templates", and after I rebuilt my
private development repository I've been running with the
version without a fix I personally had.  I've pushed out the fix
in the master branch.

I'll look at your patch to git-apply next.