[PATCH] annotate: Use qx{} for pipes on activestate.
From: Ryan Anderson <hidden>
Date: 2016-06-15 22:42:20
Subsystem:
the rest · Maintainer:
Linus Torvalds
Note: This needs someone to tell me what the value of $^O is on ActiveState. Signed-off-by: Ryan Anderson <redacted> --- As always, available in http://h4x0r5.com/~ryan/git/ryan.git/ annotate-upstream Randal, does this look basically the right approach here? (I would like to make that glob I use not a global, but I can't seem to figure out how at the moment.) git-annotate.perl | 43 ++++++++++++++++++++++++++++++++++++++++++- 1 files changed, 42 insertions(+), 1 deletions(-) a927bb08b9b319cc3832fcf354a75e3760af593c
diff --git a/git-annotate.perl b/git-annotate.perl
index ee8ff15..f9c2c6c 100755
--- a/git-annotate.perl
+++ b/git-annotate.perl@@ -431,8 +431,20 @@ sub gitvar_name { return join(' ', @field[0...(@field-4)]); } - sub open_pipe { + if ($^O eq '##INSERT_ACTIVESTATE_STRING_HERE##') { + return open_pipe_activestate(@_); + } else { + return open_pipe_normal(@_); + } +} + +sub open_pipe_activestate { + tie *fh, "Git::ActiveStatePipe", @_; + return *fh; +} + +sub open_pipe_normal { my (@execlist) = @_; my $pid = open my $kid, "-|";
@@ -445,3 +457,32 @@ sub open_pipe { return $kid; } + +package Git::ActiveStatePipe; +use strict; + +sub TIEHANDLE { + my ($class, @params) = @_; + my $cmdline = join " ", @params; + my @data = qx{$cmdline}; + bless { i => 0, data => \@data }, $class; +} + +sub READLINE { + my $self = shift; + if ($self->{i} >= scalar @{$self->{data}}) { + return undef; + } + return $self->{'data'}->[ $self->{i}++ ]; +} + +sub CLOSE { + my $self = shift; + delete $self->{data}; + delete $self->{i}; +} + +sub EOF { + my $self = shift; + return ($self->{i} >= scalar @{$self->{data}}); +}
--
1.2.3.g9ca3