Re: [PATCH] fmt-merge-msg: avoid open "-|" list form for Perl 5.6
From: Andreas Ericsson <hidden>
Date: 2016-06-15 22:42:20
Alex Riesen wrote:
On 2/23/06, Alex Riesen [off-list ref] wrote:quoted
On 2/23/06, Junio C Hamano [off-list ref] wrote:quoted
"Alex Riesen" [off-list ref] writes:quoted
I'll keep that in mind. But there are places where a safe pipe is unavoidable (filenames. No amount of careful quoting will save you).Huh?Because you never know what did the next interpreter took for unquoting: $SHELL, /bin/sh cmd /c, or something else.And that stupid activestate thing actually doesn't use any. Just tried: perl -e '$,=" ";open(F, "sleep 1000 ; # @ARGV |") and print <F>' It passed the whole string "1000 ; # @ARGV" to sleep from $PATH. It failed to sleep at all, of course. The same code works perfectly on almost any UNIX system.
Not to be unhelpful or anything, but activestate perl seems to be quite a lot of bother. Is it worth supporting it? -- Andreas Ericsson andreas.ericsson@op5.se OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231