On Wed, 22 Feb 2006, Nicolas Pitre wrote:
On Wed, 22 Feb 2006, Junio C Hamano wrote:
quoted
I like this, but like the "every second or every percent
whichever comes first" unpack-objects does even better. How
about something like this on top of your patch?
Well... my concern is (if I'm right) that this status is generated
remotely and sent over the network when performing a fetch. The "every
percent" might in this case generate quite some significant overhead if
the pack is small.
Well, my thinking behind the original unpack-objects behaviour was that we
don't really care about the max 100 extra packets.
The days of 150 baud line printers are gone. I cannot imagine any valid
situation where you can't send a hundred small packets to update the
screen.. And it did make a nice visual difference.
(In fact, over a network, if the line really is slow, you'll find that
Nagle will fix things, and you'll just see one extra - but obviously
slightly bigger - packet).
Linus